Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : JwtAuthenticationFilter 제외 endpoint 수정 #184

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix : JwtAuthenticationFilter 제외 endpoint 수정 #184

merged 1 commit into from
Nov 18, 2024

Conversation

rladmstn
Copy link
Contributor

📌 Related Issue

close #183

🚀 Description

  • JwtAuthenticationFilter에서 토큰 검증을 제외하는 엔드포인트를 /api/users/sign-in과 /api/users/sign-up으로 수정했습니다.
  • 그냥 기존의 회원가입, 로그인 엔드포인트 수정된거 적용한겁니다.
  • 위 엔드포인트로 들어오는 API 요청은 JWT에 대한 유효성 검증을 진행하지 않는다고 보심 됩니다.

📢 Review Point

📚Etc (선택)

@rladmstn rladmstn added the bug 버그 수정 label Nov 17, 2024
@rladmstn rladmstn requested review from s-hwan and sh0723 November 17, 2024 04:39
@rladmstn rladmstn self-assigned this Nov 17, 2024
@rladmstn rladmstn changed the title fix : JwtAuthenticationFilter 제외 엔드포인트 수정 fix : JwtAuthenticationFilter 제외 endpoint 수정 Nov 17, 2024
s-hwan
s-hwan approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@s-hwan s-hwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조아👍

@sh0723
Copy link
Contributor

sh0723 commented Nov 18, 2024

구욷

@sh0723 sh0723 merged commit 7c5f841 into develop Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwangjokim hwangjokim hwangjokim approved these changes

@s-hwan s-hwan s-hwan approved these changes

@sh0723 sh0723 Awaiting requested review from sh0723

Assignees

@rladmstn rladmstn

Labels
bug 버그 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix : JwtAuthenticationFilter 제외하는 endpoint 수정
4 participants
@rladmstn @sh0723 @s-hwan @hwangjokim