feat : 공지, 랭킹 목록 조회 페이징 적용 및 잡다한 것들 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0723
approved these changes
Nov 21, 2024
|
|
||
| return PageableExecutionUtils.getPage(query.fetch(), pageable, countQuery::fetchOne); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
호옥시 이부분은 어디서 쓰나요..? 위에 페이징으로 받은 리스트가 있는데 다른 곳에서 쓰는게 있나요?
There was a problem hiding this comment.
회원이 탈퇴할 때 AOP를 사용해서 랭킹을 새로 갱신해야할 때가 있었습니다! 그 때 그룹 멤버들에 대해 페이징 없이 모든 리스트를 가져와야 해서 얘도 필요합니담
| if (errors.hasErrors()) | ||
| throw new RequestException("그룹 생성 요청이 올바르지 않습니다.", errors); | ||
| GroupCodeResponse inviteCode = studyGroupService.createGroup(user, request, profileImage); | ||
| GroupCodeResponse inviteCode = studyGroupService.createGroup(user, request, groupImage); |
There was a problem hiding this comment.
앗 이부분은 제가 했어야한건데.. 감사함돵 ㅜ.ㅜ
|
이거 컨플릭 생겨서 제가 머지는 안할게요! |
self merge 하겠습니다- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Related Issue
close #185
🚀 Description
profileImage필드명도groupImage로 변경해달란 요청이 있어서 했습니다.📢 Review Point
📚Etc (선택)