feat : 문제 생성 시 잘못된 링크 예외 조건 추가 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0723
reviewed
Nov 21, 2024
| @@ -337,7 +337,7 @@ private String getProblemTitle(JsonNode problemDetails) { | |||
| private String getProblemId(CreateProblemRequest request) { | |||
| String url = request.link(); | |||
| String[] parts = url.split("/"); | |||
| if (!parts[2].equals("www.acmicpc.net")) | |||
| if (parts.length < 3 || !parts[2].equals(BOJ_PROBLEM_URL)) | |||
There was a problem hiding this comment.
parts[2]를 접근해야 그 위치부터 백준 URL 검증이 되나봐요! 기존 코드에서 parts[2]를 접근하고 있는데 길이가 3인건 체킹이 안돼서 거기서 오류난지라 그 부분을 추가한겁니다!
There was a problem hiding this comment.
아 string의 길이에 대한 length가 아니고 /이걸 기준으로 쪼갠 string 배열의 길이를 체크하는거네요?!
알겠씀다!
sh0723
approved these changes
Nov 21, 2024
| @@ -337,7 +337,7 @@ private String getProblemTitle(JsonNode problemDetails) { | |||
| private String getProblemId(CreateProblemRequest request) { | |||
| String url = request.link(); | |||
| String[] parts = url.split("/"); | |||
| if (!parts[2].equals("www.acmicpc.net")) | |||
| if (parts.length < 3 || !parts[2].equals(BOJ_PROBLEM_URL)) | |||
There was a problem hiding this comment.
아 string의 길이에 대한 length가 아니고 /이걸 기준으로 쪼갠 string 배열의 길이를 체크하는거네요?!
알겠씀다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Related Issue
close #189
🚀 Description
parts크기가 3 미만으로 될 경우도 유효하지 않은 백준 링크로 예외던지도록 조건 추가했습니다.📢 Review Point
📚Etc (선택)