Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update linter.yml to not validate using isort #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mdhishaamakhtar
Copy link

isort and black conflict with each other. Hence, disabling isort.
@SaurusXI @BRO3886 @SphericalKat

isort and black conflict with each other. Hence, disable isort.
@SaurusXI
Copy link
Contributor

@mdhishaamakhtar perhaps this is a better solution. You can set the path for isort config by setting the PYTHON_ISORT_CONFIG_FILE variable for isort

@SaurusXI
Copy link
Contributor

@mdhishaamakhtar put the config file in the .github folder, since its only actions specific. The config file should be set up according to the issue I linked above.

@mdhishaamakhtar
Copy link
Author

There is no config file. And putting it in the .github folder won't help since github actions consider project root as the working directory. And this isn't any actions specific thing. In general when someone linting their code before pushing this file should still be there.

@SaurusXI
Copy link
Contributor

You'll have to write a config file with config options according to the issue I linked to avoid isort conflicting with black - just adding a config path to the super linter action won't help.
And yes, someone might want to use it in their project - but this template is not python specific so it doesn't make sense to put the config in the project root. And they could always pull it out of .github if they want.
Therefore this is in fact actions only, further if you're using black you wouldn't even need the config. For these reasons, put it in .github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants