Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#101: 웨일비 데이터 크롤링 추가 #102

Merged
merged 7 commits into from
Sep 18, 2023
Merged

Feat/#101: 웨일비 데이터 크롤링 추가 #102

merged 7 commits into from
Sep 18, 2023

Conversation

pp449
Copy link
Member

@pp449 pp449 commented Sep 17, 2023

🤠 개요

  • 부경대 웨일비 홈에 있는 데이터들을 크롤링하여 DB에 저장하는 로직을 추가했어요
  • DB 의 데이터를 반환하는 엔드포인트를 추가했어요
  • 테스트도중 어느 학과인지 모르겠지만 졸업요건 크롤링쪽에 에러가 발생하는 문제를 발견했어요,,

💫 설명

image

📷 스크린샷 (Optional)

@pp449 pp449 added the ✨ feat label Sep 17, 2023
@pp449 pp449 self-assigned this Sep 17, 2023
hwinkr
hwinkr approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@hwinkr hwinkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 확실히 하드코딩 보다는 크롤링을 통해서 보여주는 것이 유연성이 좋을 것 같네요~
졸업요건은 제가 한번 알아볼게요

@pp449 pp449 merged commit 580b5f2 into dev Sep 18, 2023
@pp449 pp449 deleted the feat/#101 branch September 18, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwinkr hwinkr hwinkr approved these changes

Assignees

@pp449 pp449

Labels
✨ feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pp449 @hwinkr