Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/#112: push 알림 실패해도 나머지 인원들에게 알림 전송하도록 수정 #113

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Fix/#112: push 알림 실패해도 나머지 인원들에게 알림 전송하도록 수정 #113

merged 3 commits into from
Sep 26, 2023

Conversation

pp449
Copy link
Member

@pp449 pp449 commented Sep 26, 2023

🤠 개요

  • closes: Fix: web-push 로직 변경 #112
  • push 알림 실패해도 나머지 인원들에게 알림 전송하도록 수정했어요
  • push 알림을 실패한 토큰은 DB 에서 제거하도록 했어요

💫 설명

📷 스크린샷 (Optional)

@pp449 pp449 added the 🛠 fix label Sep 26, 2023
@pp449 pp449 self-assigned this Sep 26, 2023
hwinkr
hwinkr approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@hwinkr hwinkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@pp449 pp449 merged commit 7f57537 into dev Sep 26, 2023
@pp449 pp449 deleted the fix/#112 branch September 26, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwinkr hwinkr hwinkr approved these changes

Assignees

@pp449 pp449

Labels
🛠 fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: web-push 로직 변경
2 participants
@pp449 @hwinkr