Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reviewed] [Player Avatar] Add a new custom object for the profile picture from GDevelop accounts #1514

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

Bouh
Copy link
Contributor

@Bouh Bouh commented Jan 31, 2025

The players need to change their picture by themself on Gravatar, soon the avatar will be editable on their GDevelop profile.

@Bouh Bouh requested a review from a team as a code owner January 31, 2025 20:10
Copy link
Contributor

@D8H D8H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for the extension descriptions:

extensions/reviewed/PlayerAvatar.json Outdated Show resolved Hide resolved
extensions/reviewed/PlayerAvatar.json Outdated Show resolved Hide resolved
Comment on lines +19 to +21
"UI",
"Avatar",
"GDevelop"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "UI" is the category
  • "Avatar" is in the name
  • "GDevelop" I get you mean "GDevelop services" but why would someone search GDevelop in extensions?
Suggested change
"UI",
"Avatar",
"GDevelop"
"Multiplayer"

extensions/reviewed/PlayerAvatar.json Outdated Show resolved Hide resolved
@Bouh Bouh requested a review from a team as a code owner January 31, 2025 20:33
Copy link
Contributor

@D8H D8H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@D8H D8H changed the title Add a new custom object: Player Avatar, to use the picture profile from the GDevelop built-in multiplayer. [Reviewed] [Player Avatar] Add a new custom object to use the picture profile from the GDevelop built-in multiplayer. Feb 3, 2025
@D8H D8H added ✨ New extension A new extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. labels Feb 3, 2025
@D8H D8H changed the title [Reviewed] [Player Avatar] Add a new custom object to use the picture profile from the GDevelop built-in multiplayer. [Reviewed] [Player Avatar] Add a new custom object to use the profile picture from the GDevelop built-in multiplayer. Feb 3, 2025
@D8H D8H changed the title [Reviewed] [Player Avatar] Add a new custom object to use the profile picture from the GDevelop built-in multiplayer. [Reviewed] [Player Avatar] Add a new custom object with the profile picture from the GDevelop built-in multiplayer. Feb 3, 2025
@D8H D8H changed the title [Reviewed] [Player Avatar] Add a new custom object with the profile picture from the GDevelop built-in multiplayer. [Reviewed] [Player Avatar] Add a new custom object with the profile picture from GDevelop accounts Feb 3, 2025
@D8H D8H changed the title [Reviewed] [Player Avatar] Add a new custom object with the profile picture from GDevelop accounts [Reviewed] [Player Avatar] Add a new custom object for the profile picture from GDevelop accounts Feb 3, 2025
@Bouh Bouh merged commit 2c164ac into main Feb 3, 2025
4 checks passed
@Bouh Bouh deleted the add-avatar-extension branch February 3, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ New extension A new extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging.
Projects
Status: Added to GDevelop
Development

Successfully merging this pull request may close these issues.

2 participants