Feature/mfmehari/new dataatm in s2sv3 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfmehari
added
enhancement
amolod
approved these changes
Oct 9, 2024
This was referenced Oct 10, 2024
Closed
|
Thank you @amolod! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new DataAtm has been backported from the current GEOS version to the S2Sv3 model.
It includes the atmospheric component of OASIM (Ocean and Atmosphere Spectral Irradiance Model) that is used to force OBIO (NOBM).
In the coupled run the GOCART AERO_DP bundle consists of 20 groups of aerosols. When the model is coupled to DataAtm and OBIO, a corresponding AERO_DP bundle is created in DataAtm GC that consists only the 5 groups of aerosols that OBIO needs. For this reason, the way Surf GC handles the AERO_DP bundle has been modified to accommodate the two possible sources of the bundle. Previously, Surf GC expected all the 20 groups of GOCART aerosols to be present in the AERO_DP bundle, but now it has been tailored to processes any number out of the 20 groups that exist in the AERO_DP bundle.
The changes have passed the regression test.
It is a zero-diff PR.