Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto PR - develop β†’ MAPL-v3 - Bug fix for optional input arg "conserve_ice10_tzero" (StieglitzSnow.F90) #1026

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 4, 2024

πŸ“ Automatic PR: develop β†’ release/MAPL-v3

Description

Bug fix for optional input arg "conserve_ice10_tzero" (StieglitzSnow.F90)

An optional input argument ("conserve_ice10_tzero") was used in an if statement, but the optional input argument may not be provided by the calling routine.
In the GCM, the optional argument is provided in both calls to StieglitzSnow_relayer(). In the LDAS, however, the optional argument is not always provided.
The fix is to use the local variable ("conserve_ice10_tzero_tmp"), which always exists, in the if statement.

πŸ“ Modified files

.../GEOSphysics_GridComp/GEOSsurface_GridComp/Shared/StieglitzSnow.F90 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

gmao-rreichle and others added 2 commits November 4, 2024 14:34
…F90)

An optional input argument ("conserve_ice10_tzero") was used in an if statement, but the optional input argument may not be provided by the calling routine. 
In the GCM, the optional argument is provided in both calls to StieglitzSnow_relayer().   In the LDAS, however, the optional argument is not always provided. 
The fix is to use the local variable ("conserve_ice10_tzero_tmp"), which always exists, in the if statement.
…_tzero

Bug fix for optional input arg "conserve_ice10_tzero" (StieglitzSnow.F90)
@github-actions github-actions bot requested review from a team as code owners November 4, 2024 22:29
@github-actions github-actions bot added automatic Automatic Pull Request MAPL3 MAPL 3 Related Skip Changelog labels Nov 4, 2024
@mathomp4 mathomp4 merged commit e84a336 into release/MAPL-v3 Nov 4, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automatic Automatic Pull Request MAPL3 MAPL 3 Related Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants