Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI tests with Debugging flags on found a bug in GFDL Microphysics. Namely the code has:
The issue is that in the k-loop both
TOT_PREC_LS
andAREA_LS_PRC
are uninitialized in the first run through the loop.My fix is to initialize to 0.0 before going into the loop. I assume this is right, but I'll defer to @wmputman.
ETA: My editor cleaned up the whitespace, so the file comparison is not too nice to look out without ignoring whitespace. See:
https://github.com/GEOS-ESM/GEOSgcm_GridComp/pull/1035/files?w=1