Bugfix: mean land elevation + v13 bcs #1049
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….F90, mkEASETilesParam.F90)
…Sgcm_GridComp into feature/wjiang/nc4_tilefile
…ice on EASE grid; cleanup and documentation
…ram.F90, mkEASETilesParam.F90, rmTinyCatchParaMod.F90)
…butes() [formerly catchment_def()] (rmTinyCatchParaMod.F90)
1)add defaltion level 2)change names, i.e, i_indg and i_indeg_ocn 3)add N_grids 4)correct the missing values 5)correct the unit of area
biljanaorescanin
added
Not 0-diff for BCS
0 diff
gmao-rreichle
changed the base branch from
feature/wjiang/nc4_tilefile
to
develop
gmao-rreichle
changed the base branch from
develop
to
feature/wjiang/nc4_tilefile
biljanaorescanin
changed the base branch from
feature/wjiang/nc4_tilefile
to
develop
gmao-rreichle
approved these changes
Feb 3, 2025
lcandre2
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
1. Update Target Mean Elevation for Land Tiles
make_bcs records the elevation of each land tile in the catchment.def file, based on the topography data underlying the Pfafstetter catchments. To ensure that the mean elevation of the land tiles matches that computed from the topography used for the atmosphere (NCAR GMTED TOPO 30arcsec), a scaling factor is applied to the land tile elevations before recording them in the catchment.def file.
Previously, make_bcs used a hardcoded value of 614.649 m for the target mean land tile elevation computed from NCAR GMTED TOPO 30arcsec. This value is the straight average across the tiles, whereas the mean adjustment uses the tile-area weighted mean elevation, which resulted in an error in the mean elevation scaling in all existing bcs versions.
This PR corrects the hardcoded value for the target mean land elevation to 656.83 m, which reflects the cosine-lat-weighted mean elevation from the NCAR GMTED TOPO 30arcsec dataset.
Impact: Ensures that land elevation scaling is based on the correct target mean elevation. Results in differences in the land tile elevations in catchment.def when reproducing existing bcs versions, hence the PR is non-zero-diff for make_bcs. Since the land tile elevations from catchment.def are not used by the GCM or the LDAS, this PR is trivially zero-diff for the GCM and the LDAS.
2. Release of v13 BCS set for GCM v12
Defines new v13 bcs dataset for use with GCM v12. The v13 bcs data are identical to v12 data except for the aforementioned land tile elevations and the associated topography data for the atmosphere. The latter are added to the bcs manually at this time. Work is in progress to include the processing of the topography for the atmosphere into make_bcs. Adding a new set of bcs only impacts make_bcs and is trivially zero-diff for the GCM and the LDAS.
Contingencies:
Before merging this PR, both #909 and #1028 have to be merged.
Base of PR should eventually be
develop. (Currently, it isfeature/wjiang/nc4_tilefileof #1028.)@wmputman @rdkoster @weiyuan-jiang