Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off GOSWIM via N_constit=0 #1050

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gmao-rreichle
Copy link
Contributor

The present PR attempts to turn off GOSWIM by setting the number of constituents to 0.

GOSWIM is a snow impurity scheme that was implemented in GEOS but has not been used.

Previously, N_constit=9 was hardwired and GOSWIM calculations were executed even though GOSWIM was never used. To turn off GOSWIM, the GCM's rc parameter AEROSOL_DEPOSITION was set to 0, which forced the constituent mass and the deposition rates to remain zero, but the many GOSWIM do loops through the 9 constituents were still executed, thus multiplying and adding lots zeros many times.

If needed, original behavior can be recovered by setting N_constit=N_constit_GOSWIM=9

Remaining tasks:

  • verify 0-diff
  • quantify improvement in execution speed (if any)
  • update AEROSOL_DEPOSITION in GEOS_SurfaceGridComp.rc
  • additional cleanup if desired (e.g., make N_constit a configurable input)

@gmao-rreichle gmao-rreichle added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant