Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor implicit none to type,external #3002

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion Apps/Comp_Testing_Driver.F90
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ program comp_testing_driver
use MAPL_TimeDataMod
use MAPL_GridManagerMod

implicit none
implicit none (type, external)

call main()

Expand Down
4 changes: 2 additions & 2 deletions Apps/Regrid_Util.F90
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module regrid_util_support_mod
use MAPL
use gFTL_StringVector

implicit NONE
implicit none (type)

public

Expand Down Expand Up @@ -336,7 +336,7 @@ Program Regrid_Util
use regrid_util_support_mod
use mpi

implicit NONE
implicit none (type)

type(DistributedProfiler), target :: t_prof
type (ProfileReporter) :: reporter
Expand Down
8 changes: 4 additions & 4 deletions Apps/mapl_acg.pl
Original file line number Diff line number Diff line change
Expand Up @@ -1055,7 +1055,7 @@ sub gcF90code {
use ESMF
use MAPL_Mod

Implicit NONE
implicit none (type, external)
Private

! !PUBLIC MEMBER FUNCTIONS:
Expand Down Expand Up @@ -1198,7 +1198,7 @@ sub gcF90code {

! !USES:

implicit NONE
implicit none (type, external)

! !ARGUMENTS:

Expand Down Expand Up @@ -1279,7 +1279,7 @@ sub gcF90code {

! !USES:

implicit NONE
implicit none (type, external)

! !ARGUMENTS:

Expand Down Expand Up @@ -1360,7 +1360,7 @@ sub gcF90code {

! !USES:

implicit NONE
implicit none (type, external)


! !ARGUMENTS:
Expand Down
6 changes: 3 additions & 3 deletions Apps/time_ave_util.F90
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ program time_ave
use, intrinsic :: iso_fortran_env, only: int32, int64, int16, real32, real64
use ieee_arithmetic, only: isnan => ieee_is_nan

implicit none
implicit none (type)

integer comm,myid,npes,ierror
integer imglobal
Expand Down Expand Up @@ -133,7 +133,7 @@ program time_ave

!call timebeg ('main')

call mpi_init ( ierror )
call mpi_init ( ierror )
_VERIFY(ierror)
comm = mpi_comm_world
call mpi_comm_rank ( comm,myid,ierror )
Expand Down Expand Up @@ -1386,7 +1386,7 @@ function local_esmf_timeset(yymmdd,hhmmss,rc) result(etime)
end function local_esmf_timeset

function defined ( q,undef )
implicit none
implicit none (type, external)
logical defined
real q,undef
defined = q /= undef
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Replace all `implicit none` with `implicit none(type, external)` in all Fortran files

### Fixed

### Removed
Expand Down
2 changes: 1 addition & 1 deletion MAPL/MAPL.F90
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module MAPL
use MAPL_OpenMP_Support, only : MAPL_Interval => Interval
use MAPL_Profiler, initialize_profiler =>initialize, finalize_profiler =>finalize
use MAPL_FieldUtils
implicit none
implicit none (type, external)
end module MAPL

module MAPL_Mod
Expand Down
2 changes: 1 addition & 1 deletion MAPL_cfio/ESMF_CFIOBaseMod.F90
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module ESMF_CFIOBaseMod
implicit none
implicit none (type, external)
include "netcdf.inc"
end module ESMF_CFIOBaseMod
4 changes: 2 additions & 2 deletions MAPL_cfio/ESMF_CFIOEosMod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module ESMF_CFIOEosMod
use ESMF_CFIOFileMod
use ESMF_CFIOwGrADSMod, only : CFIO_wGrADS
use ESMF_CFIOrGrADSMod, only : CFIO_rGrADS
implicit none
implicit none (type, external)
!------------------------------------------------------------------------------
! !PRIVATE TYPES:
private
Expand Down Expand Up @@ -699,7 +699,7 @@ subroutine EOS_Create_(cfio, fname, title, source, contact, amiss, &
!
! !USES:
!
Implicit NONE
implicit none (type, external)
!
! !INPUT PARAMETERS:
!
Expand Down
2 changes: 1 addition & 1 deletion MAPL_cfio/ESMF_CFIOFileMod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ subroutine ESMF_CFIOSet(cfio, cfioObjName, varObjs, grids, grid, &
attIntName, attInt, format, &
expid, isCyclic, isOpen, nSteps, fNameTmplt, &
deflate, formatVersion, rc )
implicit NONE
implicit none (type, external)

!
! !INPUT PARAMETERS:
Expand Down
2 changes: 1 addition & 1 deletion MAPL_cfio/ESMF_CFIOGridMod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module ESMF_CFIOGridMod
! !USES:
use ESMF_CFIOUtilMod, only : MLEN, MVARLEN
use, intrinsic :: ISO_FORTRAN_ENV, only: REAL64
implicit none
implicit none (type, external)

!------------------------------------------------------------------------------
! !PRIVATE TYPES:
Expand Down
6 changes: 3 additions & 3 deletions MAPL_cfio/ESMF_CFIOMod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ module ESMF_CFIOMod
#endif
use esmf, only: ESMF_UtilStringUpperCase
use, intrinsic :: iso_fortran_env, only: REAL32
implicit none
implicit none (type, external)
!------------------------------------------------------------------------------
! !PRIVATE TYPES:
private
Expand Down Expand Up @@ -894,7 +894,7 @@ end subroutine ESMF_CFIOFileClose
!
subroutine ESMF_CFIODownBit3D_ ( x, xr, nbits, undef, flops, rc )

implicit NONE
implicit none (type, external)
!
! !INPUT PARAMETERS:
!
Expand Down Expand Up @@ -957,7 +957,7 @@ end subroutine ESMF_CFIODownBit3D_
!
subroutine ESMF_CFIODownBit2D_ ( x, xr, nbits, undef, flops, rc )

implicit NONE
implicit none (type, external)

!
! !INPUT PARAMETERS:
Expand Down
4 changes: 2 additions & 2 deletions MAPL_cfio/ESMF_CFIOSdfMod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ module ESMF_CFIOSdfMod
use netcdf
use, intrinsic :: ISO_FORTRAN_ENV, only: INT16, REAL32, REAL64

implicit none
implicit none (type, external)
!------------------------------------------------------------------------------
! !PRIVATE TYPES:
private
Expand Down Expand Up @@ -1874,7 +1874,7 @@ subroutine CFIO_Create_ ( cfio, rc )
!
! !USES:
!
Implicit NONE
implicit none (type, external)
!
! !INPUT PARAMETERS:
!
Expand Down
Loading