Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2845. Allow ESMF_CONFIG_FILE to specify ESMF control file #3174

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Nov 12, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This PR adds the ability for users to set an environment variable, ESMF_CONFIG_FILE, that can point to a file where pre ESMF_Initialize values can be set. Previously, the file had to be called ESMF.rc. Now, it looks at ESMF_CONFIG_FILE and if that isn't set, it then looks for ESMF.rc (for backwards compatibility).

I have tested this with GEOS and it works as expected.

@tclune if you have time, let me know if you have preferences for what to call the environment variable, etc.

Related Issue

Closes #2845

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 12, 2024
@mathomp4 mathomp4 self-assigned this Nov 12, 2024
@mathomp4 mathomp4 marked this pull request as ready for review November 12, 2024 19:36
@mathomp4 mathomp4 requested a review from a team as a code owner November 12, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants