Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added return to fetch_data #3179

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Added return to fetch_data #3179

wants to merge 1 commit into from

Conversation

weiyuan-jiang
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This PR addresses the issue #3177 . It is not the subroutine deserialize_base, but subroutine fetch_data

Related Issue

@weiyuan-jiang weiyuan-jiang added 🪲 Bug Something isn't working 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels Nov 13, 2024
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner November 13, 2024 20:36
tclune
tclune approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description in issue is incorrect. But ... @weiyuan-jiang managed to find other similar issues nonetheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@818Nawaf 818Nawaf 818Nawaf approved these changes

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🪲 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiyuan-jiang @tclune @818Nawaf