Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accumulation_type to VariableSpec and ComponentSpecParser #3205

Merged

Conversation

darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

For MAPL3 time averaging, the VariableSpec needs a variable for accumulation_type, and ComponentSpecParser needs to parse accumulutation_type from the ESMF_HConfig. This PR implements these capabilities.

@darianboggs darianboggs added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Dec 2, 2024
@darianboggs darianboggs self-assigned this Dec 2, 2024
@darianboggs darianboggs requested a review from a team as a code owner December 2, 2024 22:38
@darianboggs darianboggs merged commit 5d2446c into release/MAPL-v3 Dec 3, 2024
37 checks passed
@darianboggs darianboggs deleted the feature/wdboggs/varspec_add_accumulation branch December 3, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants