Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{P} [Tech Debt] Warnings as Errors #89

Open
FlorianDeconinck opened this issue Oct 29, 2024 · 0 comments
Open

{P} [Tech Debt] Warnings as Errors #89

FlorianDeconinck opened this issue Oct 29, 2024 · 0 comments

Comments

@FlorianDeconinck
Copy link
Collaborator

FlorianDeconinck commented Oct 29, 2024 •
edited
Loading

NDSL, gt4py.cartesian and DaCe are emitting warnings on different configuration. Those are too numerous and tend to be ignored. We aim to turn out the equivalent to -W error everywhere to force clean up.
@FlorianDeconinck FlorianDeconinck transferred this issue from GEOS-ESM/NDSL Oct 29, 2024
@FlorianDeconinck FlorianDeconinck mentioned this issue Oct 29, 2024
Open
2 tasks
This was referenced Oct 29, 2024
Merged
Merged
Merged
egparedes pushed a commit to GridTools/gt4py that referenced this issue Oct 29, 2024
@romanc
tests: fix name of license file configured in pyproject.toml (#1718)
c78bafd 
The license file configured in `pyproject.toml` was missing the `*.txt`
extension, leading to warnings in tests.

Parent: GEOS-ESM/SMT-Nebulae#89
egparedes pushed a commit to GridTools/gt4py that referenced this issue Oct 31, 2024
@romanc
ci: use actions/checkout@v4 and actions/setup-python@v5 (#1717)
f1c9d83 
This PR updates the GitHub Actions (GHA) workflows to use
`actions/checkout@v4` instead of `v3` (or `v2` in the cartesian case)
and `actions/setup-python@v5`. Development for `actions/checkout@v3` and
`actions/setup-python@v4` stopped ~1 year ago and GH is currently
enforcing newer node versions than the one that these actions were
designed with, leading to the following warnings

![image](https://github.com/user-attachments/assets/52924274-a00c-451c-a5a3-810fba1e6b27)
_warnings in next workflows_


![image](https://github.com/user-attachments/assets/af7f0027-f6d1-4998-a28a-c76c13dcaebb)
_warnings in cartesian workflows_

`deploy_release` action was following `actions/checkout@master`. Was
this on purpose? Happy to revert if so. Unless there's a good reason, I
suggest to keep all actions pinned at ideally the same major version.

`pre-commit/action` was updated to keep its dependencies up to date and
avoid transitive warnings similar to the ones above.

No changes made to currently disabled workflows, i.e. the ones under
`.github/workflows/_disabled/`.

Parent: GEOS-ESM/SMT-Nebulae#89
@romanc romanc mentioned this issue Nov 1, 2024
Merged
github-merge-queue bot pushed a commit to spcl/dace that referenced this issue Nov 1, 2024
@romanc
CI: Update checkout and setup-python actions (#1718)
2c41491 
GitHub Actions workflows use outdated versions of

- actions/checkout
- actions/setup-python

These actions are built for specific node versions, which are now end of
life. While the workflows continue to run, GitHub issues a warning
(visible in the online interface) and runs them with newer versions of
node.


![image](https://github.com/user-attachments/assets/159f4d86-33f5-4d9c-ad45-a5657ad51a57)

Since both, checkout and setup-python, are basic actions, none of the
features that DaCe workflows are using changed. We might see slight
speedup from out of the box caching added to setup-python in recent
versions.

Parent issue: GEOS-ESM/SMT-Nebulae#89

Co-authored-by: Roman Cattaneo <>
@FlorianDeconinck FlorianDeconinck changed the title [Tech Debt] Warnings as Errors {P} [Tech Debt] Warnings as Errors Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FlorianDeconinck