ci: use actions/checkout@v4 and actions/setup-python@v5 #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 29, 2024 09:56
actions/checkout@v2 received that last "backport fix" in Dec 2022. Meanwhile GH is even forcing a newer node version (16 instead of 12) than what v2 was designed with.
romanc
changed the title
|
@twicki / @FlorianDeconinck continuing the quest to reduce warnings ... @egparedes / @havogt please review or re-distribute to whoever is knowledgeable / in charge of CI for the next version of gt4py As far as I can tell, we should be good again for now. We might want to look into automatic reporting of outdated GHA versions in the future. |
|
We should also be aware the |
|
cscs-ci run |
|
cscs-ci run |
havogt
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the GitHub Actions (GHA) workflows to use
actions/checkout@v4instead ofv3(orv2in the cartesian case) andactions/setup-python@v5. Development foractions/checkout@v3andactions/setup-python@v4stopped ~1 year ago and GH is currently enforcing newer node versions than the one that these actions were designed with, leading to the following warningswarnings in next workflows
warnings in cartesian workflows
deploy_releaseaction was followingactions/checkout@master. Was this on purpose? Happy to revert if so. Unless there's a good reason, I suggest to keep all actions pinned at ideally the same major version.pre-commit/actionwas updated to keep its dependencies up to date and avoid transitive warnings similar to the ones above.No changes made to currently disabled workflows, i.e. the ones under
.github/workflows/_disabled/.Parent: GEOS-ESM/SMT-Nebulae#89
Requirements
CI is running as before - just with fewer warnings.
N/A