points_to_coeffs fix - adding return #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update main with latest dev
Update main branch
* adding version 1.3.0 to docs (GEOUNED-org#274) * Update version_switcher.json Adding the new version to the documentation. * correction sphere additional plane * Adding the mention of libmamba solver to installation instructions (GEOUNED-org#280) * optimal bounbox to fix Torus bug * optimal bounbox to fix Torus bug * Torus envelope fix (partially) (GEOUNED-org#286) * Update of the documentation layout (GEOUNED-org#285) * update_of_docs * test * update 2 * update 3 * update 4 * test 5 * update 6 * update 7 * update 8 * test materials * test again * final --------- Co-authored-by: Jonathan Shimwell <[email protected]> Co-authored-by: Patrick Sauvan <[email protected]> Co-authored-by: Aljaz Kolsek (F4E) <[email protected]>
|
Hi @py1sl nice to see you over here. Looks like your PR brings in a few other commits but the intention is to add a single line. Looks like a useful addition but would it be possible to make the PR without the additional commits. Perhaps sync the dev branch in your fork and branch from that |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are a first-time contributor to GEOUNED, please read our contributing guidelines:
https://github.com/GEOUNED-org/GEOUNED/blob/main/CONTRIBUTING.md
Description
when using a plane defined by points an type error would be thrown for the coeff variable being none
On investigation this was found to be in geouned reverse in the mcnpinput in the Get_primitive_surfaces function a call is made to points_to_coeffs if the surface is a plane and is defined by points.
points_to_coeffs had no return so returned none.
simple fix to add a return coeffs to the points_to_coeffs function,
the points_to_coeffs could do with a refactor to be more pythonic and more readable
Fixes issue
Please link to any issues that this PR fixes
Checklist