fixes #77 #78
Merged
fixes #77 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psauvan
reviewed
Apr 24, 2024
| @@ -598,7 +598,7 @@ def GenTorusAnnexVSurface(face,Vparams,forceCylinder=False): | |||
| Apex = face.Surface.Center + za * axis | |||
| semiAngle = abs(math.atan(d1/(z1-za))) | |||
|
|
|||
| ConeAxis = axis if za < 0 else -axis | |||
| ConeAxis = axis if (face.Surface.Center.dot(axis) + z1 - Apex.dot(axis)) > 0.0 else -axis | |||
There was a problem hiding this comment.
You are right the current test is wrong although it worked so far.
I would prefer you to rewrite the instruction like
ConeAxis = axis if z1-za > 0.0 else -axis
|
Thanks, that is a more efficient way of checking the which side of the apex the point is. I have updated the PR. |
psauvan
approved these changes
Apr 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77 issue with cone surfaces used to limit tori extents.