Removing unused variables #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psauvan
requested changes
Apr 25, 2024
| @@ -1077,7 +1077,6 @@ def get_hyperboloid_parameters(eVal, eVect, T, k, iaxis): | |||
| elliposoid = False | |||
| if iaxis is None: | |||
| iaxis = np.argmin(np.abs(eVal)) | |||
| ellipsoid = True | |||
There was a problem hiding this comment.
This should variable not be removed. In fact there is a typo in the spelling of the variable in line 1077 "elliposoid" which is the variable used in line 1144.
Please keep the variable in line 1080 and rename the variable in lines 1077 and 1144
There was a problem hiding this comment.
excellent spot @psauvan
There was a problem hiding this comment.
I've corrected the spelling typos and put ellipsoid back as requested.
This PR now has slightly different behaviour compared to the dev branch, as it fixes an undiscovered bug. Perhaps this helps with some of the geometries that lose particles during transport
psauvan
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a few unused variables in the code.
Perhaps best to remove them