Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geouned class init now accepts arguments #85

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

shimwell
Copy link
Collaborator

@shimwell shimwell commented Apr 25, 2024

This PR allows users to pass in arguments directly to the GEOUNED class.

I put in type hints for the arguments I'm sure about.

compatibility

fully compatible with the current way of running a config file, but just gives another way of making use of the class by directly calling it with the arguments for example this is now allowed

from geouned import GEOUNED
geo = GEOUNED(stepFile='example.stp', title='geouned_is_great')

This keeps the same default values that were previously coded and set equal to the class .__dict__ attribute.

This still allows the config.ini file to be loaded in the same ways as before. We actually make use of the config file loading in the tests so this shows that the current config method still works

@psauvan psauvan merged commit ac6d21f into GEOUNED-org:dev Apr 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants