Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add topojson graph export rebase #1926

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

feat: Add topojson graph export rebase #1926

wants to merge 19 commits into from

Conversation

MichaelsJP
Copy link
Member

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

MichaelsJP and others added 11 commits December 4, 2024 17:20
@MichaelsJP
feat(topojson-export): First object definition of the new TopoJson ex…
f853345 
…port

This implements the first rough TopoJson objects to construct the coming TopoJson export endpoint.
@MichaelsJP
feat(topojson-export): Introduce proper lombok builder
f826d83
@MichaelsJP
feat(topojson-export): Introduce a separate class for Arcs
50c8a3d
@Chwiggy @MichaelsJP
refactor(topojson-export): rename Objects class to Layers
316f243
@Chwiggy @MichaelsJP
test(topojson-export): add basic endpoint ping test
9f4a5f4
@Chwiggy @MichaelsJP
feat(topojson-export): add basic endpoint
bad5b68
@Chwiggy @MichaelsJP
test(topojson-export): add simple export api ping tests
e5a32b4 
includes pingtests in various permutations of faulty and correct input
@Chwiggy @MichaelsJP
test(topojson-export): add test for export/json format
34dca5c
@Chwiggy @MichaelsJP
feat(topojson-export): work in progress topojson response generation
3b681e4
@takb @MichaelsJP
feat: add OSM id and geometry to ExportResult
9404b47
@takb @MichaelsJP
feat: usage of OSM id and geometry from ExportResult
a612fdc
@MichaelsJP
fix(topojson): Create broken setter
3e2980d 
Let's not add Lombok to existing classes. Only new ones for now. Hence, this fiel gets a typical setter.
@MichaelsJP
feat(topojson): Add topology as default type
fb9d54b
@MichaelsJP
fix(topojson): Repair wrong serialization
147f67b 
Before the "coordinates" keyword was still serialized wrongly into the topojson structure creating a wrong arcs structure.
@MichaelsJP
refactor(topojson): Merge TopoJson and TopoJsonExportResponse
cd6194f 
Reduce unnecessary duplication and streamline the export serialization with e.g. JsonExportResponse. The only difference is that it doesn't extent the ExportResponse. This is also not necessary. ExportResponse holds no value for the TopoJson export.
@MichaelsJP
test(topojson): Finish first endpoint test for topojson
dd208b4
@MichaelsJP
refactor(topojson): Remove intermediate structure Layers.java.
8fbab06 
Layers is not necessary. It can be represented by a HashMap of layers where the key is the layer name. In our case "network".
@MichaelsJP
refactor(sonarlint): Inline the profile Path variable
aff6244
@MichaelsJP MichaelsJP force-pushed the feat/add-topojson-graph-export-rebase branch from 807ea6d to aff6244 Compare December 4, 2024 21:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
99.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@takb
feat: TopoJSON copmbining arcs with same OSM id to single geometries,…
efeecf8 
… properties replacing weight with speed/distance, fallback for cases where OSM ids are not available, using OSM way geometries (with option to turn off and get only node coordinates (beeline graph) instead)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelsJP @Chwiggy @takb