Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aruco markers #511

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Aruco markers #511

wants to merge 11 commits into from

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Oct 29, 2024 •
edited
Loading

Questions:

  • How to deal w/ the large amount of images generated by Approval tests
  • Maybe reduce the number of parameters passed to the approval tests?

@matthiasschaub matthiasschaub force-pushed the aruco-markers branch 2 times, most recently from 96bd855 to 9847136 Compare November 13, 2024 00:07
@matthiasschaub
build(dep): fix opencv version to work w/ ultralytics
f216fcf
@matthiasschaub
test(approval): add pytest namer factory
29e5f38
@matthiasschaub
test(approval): add NDArray Reporter/Approver
ded3bcc
@matthiasschaub
feat(aruco): generate aruco markers
41d5928
@matthiasschaub
test(approval): add image Reporter and Approver
0f8bed7
@matthiasschaub
test(map-generation): refactor to use approval tests
ff5ee13 
refactor to use approval tests for the `generate_pdf` function
@matthiasschaub
feat(sketch-map): exchange globes with aruco markers
eab8802
@matthiasschaub
refactor: avoid import aliases and rename canv var
c479026
@matthiasschaub
feat: make aruco markers a feature flag
e703ebf 
- restore previous globe makers as default.
- aruco markers are only used if option flag is set
- add aruco markers flag to parameters of parametrized approval tests
@matthiasschaub
tests: save approved files to new directory
21a48d1 
New directories names are based on the test file names.

PytestNamer class for managing approval test file paths got updated
accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthiasschaub