Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #19

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Dev #19

wants to merge 8 commits into from

Conversation

LinHeLurking
Copy link
Member

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

53.5% 53.5% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #19 (88c36ce) into main (4bb545e) will decrease coverage by 1.28%.
The diff coverage is 45.00%.

@@             Coverage Diff              @@
##               main      #19      +/-   ##
============================================
- Coverage     72.16%   70.89%   -1.28%     
- Complexity       95       96       +1     
============================================
  Files            17       19       +2     
  Lines           636      670      +34     
  Branches         56       60       +4     
============================================
+ Hits            459      475      +16     
- Misses          139      154      +15     
- Partials         38       41       +3     
Impacted Files Coverage Δ
...ain/kotlin/com/github/gkdrateit/database/Review.kt 100.00% <ø> (ø)
...ain/kotlin/com/github/gkdrateit/service/ApiBase.kt 71.59% <0.00%> (ø)
.../com/github/gkdrateit/service/TeacherController.kt 70.00% <0.00%> (-3.34%) ⬇️
...n/com/github/gkdrateit/service/ReviewController.kt 62.06% <15.38%> (-7.17%) ⬇️
...n/com/github/gkdrateit/service/CourseController.kt 53.73% <18.75%> (+4.41%) ⬆️
...main/kotlin/com/github/gkdrateit/database/DbExt.kt 50.00% <50.00%> (ø)
...ain/kotlin/com/github/gkdrateit/permission/Role.kt 81.48% <50.00%> (ø)
...ain/kotlin/com/github/gkdrateit/database/Course.kt 86.11% <69.69%> (-13.89%) ⬇️
...kotlin/com/github/gkdrateit/config/RateItConfig.kt 81.81% <100.00%> (+0.86%) ⬆️
...in/kotlin/com/github/gkdrateit/database/DbTimer.kt 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants