NBD remove config file at right place

NBD is not yet installed in Dockerfile but via extra actions, so we need to remove config file elsewhere. Signed-off-by: Corentin LABBE <[email protected]>
GKernelCI · Jan 25, 2023 · e51d390 · e51d390
1 parent 244c98c
commit e51d390
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/lava-slave/Dockerfile b/lava-slave/Dockerfile
@@ -15,9 +15,6 @@ COPY scripts/ /usr/local/bin/
 RUN chmod a+x /usr/local/bin/*
 COPY conmux/ /etc/conmux/
 
-# LAVA issue 585
-RUN rm /etc/nbd-server/config
-
 # Caution to not use any port between the Linux dynamic port range: 32768-60999
 RUN find /usr/lib/python3/dist-packages/ -iname constants.py | xargs sed -i 's,XNBD_PORT_RANGE_MIN.*,XNBD_PORT_RANGE_MIN=61950,'
 RUN find /usr/lib/python3/dist-packages/ -iname constants.py | xargs sed -i 's,XNBD_PORT_RANGE_MAX.*,XNBD_PORT_RANGE_MAX=62000,'

diff --git a/lavalab-gen.py b/lavalab-gen.py
@@ -602,7 +602,8 @@ def main():
         if use_nbd:
             dockcomp["services"][name]["ports"].append("61950-62000:61950-62000")
             fp = open("%s/scripts/extra_actions" % workerdir, "a")
-            fp.write("apt-get -y install nbd-server\n")
+            # LAVA issue 585 need to remove /etc/nbd-server/config
+            fp.write("apt-get -y install nbd-server && rm -f /etc/nbd-server/config\n")
             fp.close()
             os.chmod("%s/scripts/extra_actions" % workerdir, 0o755)
         use_overlay_server = True