Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/test aid authorization for check upload #65

Merged

Conversation

aydarng
Copy link
Collaborator

@aydarng aydarng commented Aug 29, 2024

Requires GLEIF-IT/reg-pilot-api#42 and GLEIF-IT/vlei-verifier#36 to be merged.
Requires reg-pilo-api updated docker image and vlei-verifier updated docker image

@aydarng aydarng requested a review from 2byrds August 29, 2024 16:15
signify-ts-test/test-multiple-aids.sh Outdated Show resolved Hide resolved
signify-ts-test/test/utils/resolve-env.ts Outdated Show resolved Hide resolved
@2byrds
Copy link
Collaborator

2byrds commented Sep 2, 2024

@aydarng i triggered a rerun of the multi user test but it failed again. Remind me what is left to do.

aydarng

This comment was marked as outdated.

@aydarng aydarng requested a review from 2byrds September 3, 2024 10:25
.github/workflows/tests-multi-user.yml Outdated Show resolved Hide resolved
@aydarng aydarng requested a review from 2byrds September 4, 2024 16:00
Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. We need to consolidate repeated code, but can do that next.

@2byrds 2byrds merged commit 9762957 into GLEIF-IT:main Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants