Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final changes for glvis-4.3 #284

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Final changes for glvis-4.3 #284

wants to merge 3 commits into from

Conversation

tzanio
Copy link
Member

@tzanio tzanio commented Jun 19, 2024

πŸ“† Target release date: July 15, 2024

🟑 In Progress:

πŸ”΄ TODO:

🟀 Optional:

βšͺ After the release:

🟒 DONE:

⚫ Postponed:

@tzanio tzanio requested a review from a team June 19, 2024 00:58
@tzanio tzanio self-assigned this Jun 19, 2024
@tzanio tzanio added the release label Jun 19, 2024
@tzanio tzanio added this to the glvis-4.3 milestone Jun 19, 2024
@tzanio tzanio mentioned this pull request Jun 19, 2024
Copy link

@acfisher acfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@najlkin
Copy link
Contributor

najlkin commented Jun 24, 2024

What is the idea with quadrature functions? Interpreting them as L2 elements would be very simple πŸ˜‰ . I have done that in the past in my codes.

@tzanio
Copy link
Member Author

tzanio commented Jun 24, 2024

What is the idea with quadrature functions? Interpreting them as L2 elements would be very simple πŸ˜‰ . I have done that in the past in my codes.

This has been discussed multiple times, but there are essentially 3 options we have considered:

  1. Plot p.w. const function on the LOR Gauss-Lobatto mesh, where each LOR element contains exactly one Gauss-Legendre quadrature point. (The p points of 1D GLL quadrature rule are interleaved by the p+1 points of the 1D GL rule)

  2. Interpret quadrature values as the dofs of an L2 grid funcion

  3. Draw a little sphere for each point

Option 3 is most general and will be required for "Support for visualization of particle data". I personally like option 1, because it does not introduce variations beyond the original data. That works only on quad/hex meshes though.

@najlkin
Copy link
Contributor

najlkin commented Jun 24, 2024

I see, we must reach consensus then what way to go, which might take longer than actually implementing it 😁 .

@tzanio
Copy link
Member Author

tzanio commented Jun 24, 2024

We can also support both options 😁

@najlkin najlkin self-assigned this Jul 1, 2024
@najlkin
Copy link
Contributor

najlkin commented Jul 8, 2024

I found out there is no smooth vizualization in 2D for vector fields atm. This could be also added, but it would require to differentiate the vector-to-scalar function πŸ€”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants