Experimental: new floating labels implementation #4870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This style of label rendering was first demonstrated on the canvas rendering PR (#2671 ) One specific technical goal that this PR enable is collapsed introns. The labels render much better in this branch because it is not cut off at the small block boundaries used in collapse PR views |
cmdcolin
force-pushed
the
new_floating_labels
branch
from
5f9c58e to
40b67f2
Compare
|
(potentially the canvas feature rendering approach could still be good to switch to entirely, but needs work...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current floating labels implementation, which keeps the label on the left side of the screen even when zoomed in, is challenged due to block based rendering (hard to tell what block is the 'left most block', and even if you did know, it is required to render in multiple blocks if it crosses block boundaries, and the SVG text used for label rendering is strictly cut off at block boundaries due to blocks containing the SVG container) and server side rendering (can't float labels with server side rendering)
An alternative to the above described challenges is 'lifting up' the label rendering to the display level
This PR is an example of this
It renders the text as plain div elements in the BaseFeatureDisplayModel