Update babel6->babel7, webpack4->webpack5 #1662
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change might not be truly needed but it modrnizes the build stack a bit and gets rid of a need to specify "export NODE_OPTIONS=--openssl-legacy-provider" on newer versions of node (newer versions of node previously enabled by removal of node-sass)
Misc note
There was a tricky thing where we need to 'cjsRequire' dompurify, and not import. With import, it adds 'use strict', which breaks dojo this.inherited statements.
This is potentially a difference vis-a-vis our babel 6 config which seemed to not care
The options regarding this are
a) not upgrade webpack (no breakage likely, but old tech stack)
b) adapt this.inherited's (tried in #1371, could break plugins)
c) this method (method from this PR, less likely to break plugins, but still small chance)
There could be a potential for breaking plugins that use import in certain ways, but the plugins can likely be adapted if they do run into it