Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dependency #22

Merged
merged 12 commits into from
Nov 14, 2023
Merged

Fix/dependency #22

merged 12 commits into from
Nov 14, 2023

Conversation

chrisdicaprio
Copy link
Collaborator

add requests extra to gql dependency. I think this will fix GNS-Science/toshi-hazard-post#14

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3569d14) 38.43% compared to head (f1cd21e) 38.97%.

Files Patch % Lines
nshm_toshi_client/general_task.py 0.00% 1 Missing ⚠️
nshm_toshi_client/toshi_client_base.py 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   38.43%   38.97%   +0.54%     
==========================================
  Files          10       10              
  Lines         268      254      -14     
  Branches       23       16       -7     
==========================================
- Hits          103       99       -4     
+ Misses        160      150      -10     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chrisbc chrisbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scanned OK

@chrisbc chrisbc merged commit 01cbbb3 into main Nov 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker image missing requests_toolbelt dependency
3 participants