Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/56 location macrons #57

Merged
merged 12 commits into from
Nov 20, 2024
Merged

Conversation

chrisdicaprio
Copy link
Collaborator

@chrisdicaprio chrisdicaprio commented Nov 19, 2024

closes #56

Provides function get_name_with_macrons that converts place names to use the correct Māori spellings with macrons.

The function relies on the Māori place names file from LINZ (https://gazetteer.linz.govt.nz/maori_names.csv) which has been added as a resource.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (a0f90c8) to head (d7bf3a1).
Report is 13 commits behind head on pre-release.

Additional details and impacted files
@@               Coverage Diff               @@
##           pre-release      #57      +/-   ##
===============================================
+ Coverage        97.99%   98.17%   +0.17%     
===============================================
  Files               17       17              
  Lines              299      328      +29     
  Branches            51       61      +10     
===============================================
+ Hits               293      322      +29     
- Misses               2        3       +1     
+ Partials             4        3       -1     
Flag Coverage Δ
unittests 98.17% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@chrisdicaprio chrisdicaprio force-pushed the feature/56-location-macrons branch from 2f854f0 to 90e8be5 Compare November 19, 2024 22:15
@chrisdicaprio chrisdicaprio marked this pull request as ready for review November 19, 2024 22:53
@chrisdicaprio chrisdicaprio merged commit 63110b9 into pre-release Nov 20, 2024
11 checks passed
@chrisdicaprio chrisdicaprio deleted the feature/56-location-macrons branch November 20, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants