Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/38 set logic options and sane defaults #39

Merged
merged 11 commits into from
Jul 18, 2023

Conversation

chrisbc
Copy link
Member

@chrisbc chrisbc commented Jul 11, 2023

closing #38

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Merging #39 (87570f9) into deploy-test (55e69b9) will decrease coverage by 0.79%.
The diff coverage is 82.97%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           deploy-test      #39      +/-   ##
===============================================
- Coverage        93.28%   92.49%   -0.79%     
===============================================
  Files               14       15       +1     
  Lines              774      826      +52     
  Branches            65       71       +6     
===============================================
+ Hits               722      764      +42     
- Misses              40       49       +9     
- Partials            12       13       +1     
Impacted Files Coverage Δ
solvis_graphql_api/composite_solution/schema.py 100.00% <ø> (ø)
solvis_graphql_api/composite_solution/cached.py 87.19% <76.81%> (-4.22%) ⬇️
...api/composite_solution/composite_rupture_detail.py 100.00% <100.00%> (ø)
...i/composite_solution/composite_rupture_sections.py 94.73% <100.00%> (ø)
...aphql_api/composite_solution/composite_solution.py 100.00% <100.00%> (ø)
...api/composite_solution/filter_set_logic_options.py 100.00% <100.00%> (ø)

Copy link
Member Author

@chrisbc chrisbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scanned OK

@chrisbc chrisbc merged commit 1b9fef1 into deploy-test Jul 18, 2023
@chrisbc chrisbc deleted the feature/38_set_logic_options_and_sane_defaults branch July 18, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants