Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/53 th sv2 db adapters #54

Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

Feature/53 th sv2 db adapters #54

wants to merge 73 commits into from

Conversation

chrisbc
Copy link
Member

@chrisbc chrisbc commented Dec 14, 2023 •
edited
Loading

closing #53

  • feature: db_adapter - use alternate database(s) for primary storage.

@chrisbc chrisbc marked this pull request as draft December 14, 2023 04:09
@chrisbc chrisbc marked this pull request as ready for review December 21, 2023 03:36
@chrisbc
Copy link
Member Author

chrisbc commented Feb 27, 2024

@chrisdicaprio re #54 (comment) there are a couple of problems here ...

  • the loading steps aren't actually using sqlite3 adapter - needs doc fix/easier env setup.
  • the the toshi-hazard-post/scratch/test_ths.py script is outside the repo so I'm not sure what it's doing.

@chrisbc chrisbc marked this pull request as ready for review March 6, 2024 00:39
@chrisbc
Copy link
Member Author

chrisbc commented Mar 6, 2024

@chrisdicaprio this is now ready for final testing in-anger :) I've updated the docs with clearer instructions for config (see docs/configuration.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdicaprio chrisdicaprio chrisdicaprio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisbc @chrisdicaprio