[GT-187] Add support for selecting mutiple sites #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sae126V
force-pushed
the
GT-187-Selecting-multiple-sites-in-a-downtime-views
branch
from
92a4be7
to
87c02c3
Compare
|
Has #475 superseded this PR? |
This PR is Having Mix and match of addressing PSR-12 issues mostly, it includes function level refractor(Minor improvements) etc. It is in draft as of now. Until I take a pull from dev to clear blockers for this. |
If that's the case, can you then update the title and description, and make it clear what PR it's waiting on to be merged first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #261
Partially address: #85 and #66 .
Addressed @gregcorbett comments:
### Suggestion 1:
Include the Site Name next to the downtime link on creation, i.e.:
New Downtimes successfully created. Please click the links below for more information.
### Suggestion 1:
Only display the start and end time once on the "Confirm Downtime" page, i.e.:
Severity: WARNING
Description: foo bar
Starting (UTC): 08/09/2023 00:00
Ending (UTC): 18/09/2023 00:00
Site Name: Brunnen GS
...
Site Name: Torch
...