Draft: Test use new build action #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGoogle
force-pushed
the
feature/use_new_build_action
branch
from
8ceba79 to
09e24c7
Compare
UncleGoogle
commented
Apr 29, 2023
Comment on lines
+34
to
+51
| # TODO - thinks about the flow for release | ||
| # | ||
| # Option 1 (simple) - release job have to be after build job | ||
| # 1 build job with upload artifacts | ||
| # 2 release job: | ||
| # - download all artifacts | ||
| # - create and publish Github release | ||
| # | ||
| # Option 2a (saves resources): | ||
| # 1. create release job | ||
| # 2. build job | ||
| # - build action (can expose build.zip inside build action) | ||
| # - upload directly to previously created release | ||
| # 3. publish release job | ||
| # Option 2b -- release job wraps build job so plugin have only build for MR and release for `master` set ups | ||
| # | ||
| # Option 3: | ||
| # - release previously build&tested artifacts (don't build them again) |
There was a problem hiding this comment.
@urwrstkn8mare planning futher steps here. Please take a look 👀
There was a problem hiding this comment.
@UncleGoogle I think we should use Option 3. So that all commits to other branches will have build artifacts so other people can download it and test it. But when changes are merged to master (with mandatory version bump) we can release the previously built artifact. Is that something that sounds good to you? Option 2b might also be able to be used instead for the same flow I think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test GOG-Nebula/action-build-plugin#1