retrieves app and genome id's (rather than hard code) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you considered adding the hard-coded ID's as a fallback, in case the retrieval doesn't work for whatever reason, and logging it if that situation arises? |
|
Considered it, but these ID's change pretty quickly (4 weeks if my memory serves), so updating the code to include the old one would be a constant maintenance task.
Option of writing the current one to disk every time it's successul, but that feels like over-engineering?
…----- Original message -----
From: Erik Jan Meijer ***@***.***>
To: GOG-Nebula/galaxy-integration-uplay ***@***.***>
Cc: wearepariah ***@***.***>, Author ***@***.***>
Subject: Re: [GOG-Nebula/galaxy-integration-uplay] retrieves app and genome id's (rather than hard code) (PR #4)
Date: Friday, August 18, 2023 5:10 AM
Have you considered adding the hard-coded ID's as a fallback, in case the retrieval doesn't work for whatever reason, and logging it if that situation arises?
—
Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APX3ZLDFMBPH53YMA47Y4U3XVZUDPANCNFSM6AAAAAA2EGBKMY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Doesn't seem it's changed for a good while, since https://www.gog.com/forum/general_beta_gog_galaxy_2.0/ubisoft_connect_connection_lost/post145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the rest of it needs a whole bunch of work, but this is a first step. works, but does not maintain login for more than ~2-3 days