Resolve issues with GPA on Mesa for Apitrace #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to link static if possible, because it simplifies installation and eliminates the need to dlopen.
Apitrace compiles with no rtti. If possible, allow ADDL_CFLAGS to be specified at build/configuration time.
This is only a problem due to static linking.
Mesa does not provide EGL entry points in libGL.
Mesa appends kernel version and other information to the reported device name.
Mesa does not provide the expected number of counters.
The EXT functions are part of the GL spec, and are not exposed as extensions by Mesa.
amitprakash07
force-pushed
the
master
branch
from
b9c5090 to
394b9a9
Compare
amitprakash07
force-pushed
the
master
branch
3 times, most recently
from
c7bb6f5 to
045a85e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rtti & clashes commits only exist because I am linking statically. I can understand if you don't want to take those patches, but it is easier for me to link statically.
There are many things that I didn't test/fix for the build, like the linking to a precompiled gtest lib. That's simply not the way you want to manage external dependencies on linux.
Other cross-platform projects that I have worked on use CMake or Meson for cross-platform build support. Typically, they realize right away that maintaining the build in CMake is superior to checking in Visual Studio projects to perforce.