Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permissions errors when run in github actions #8

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix permissions errors when run in github actions #8

merged 1 commit into from
Sep 12, 2024

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Sep 12, 2024 •
edited
Loading

🎫 Addresses issue: #5

🛠 Summary of changes

  • when an argument is provided to check, it is a directory to write a file to, not the filename itself.

👀 Screenshots and Evidence

Before:
Screenshot 2024-09-12 at 10 09 10 AM

After: the test passes and the artifact is downloadable

@rahearn rahearn requested a review from a team September 12, 2024 14:09
@rahearn rahearn changed the title Fix permissions errors when run in github actiosn Fix permissions errors when run in github actions Sep 12, 2024
@rahearn rahearn mentioned this pull request Sep 12, 2024
Merged
pauldoomgov
pauldoomgov approved these changes Sep 12, 2024
View reviewed changes
Copy link

@pauldoomgov pauldoomgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahearn rahearn merged commit 47f3426 into main Sep 12, 2024
1 check passed
@rahearn rahearn deleted the pass-ar-directory-to-check branch September 12, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldoomgov pauldoomgov pauldoomgov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahearn @pauldoomgov