Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build a -glr variant for use with gitlab-runner-cloudgov. #52

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Build a -glr variant for use with gitlab-runner-cloudgov. #52

merged 3 commits into from
Dec 17, 2024

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Dec 16, 2024

🎫 Addresses issue: GSA-TTS/gitlab-runner-cloudgov#68

🛠 Summary of changes

Create a -glr variant that's compatible with use as a DevTools Runner - Worker application

  • run as root user
  • pre-install known glr dependencies
  • Switch out entrypoint to remove guardrails that are useful for local dev use

@rahearn rahearn requested a review from a team December 16, 2024 19:18
@rahearn rahearn requested a review from pauldoomgov December 17, 2024 14:17
@rahearn rahearn self-assigned this Dec 17, 2024
pauldoomgov
pauldoomgov approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@pauldoomgov pauldoomgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rahearn rahearn merged commit 1c19863 into main Dec 17, 2024
1 check passed
@rahearn rahearn deleted the gitlab-ci-image branch December 17, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldoomgov pauldoomgov pauldoomgov approved these changes

@zjrgov zjrgov zjrgov approved these changes

Assignees

@rahearn rahearn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahearn @pauldoomgov @zjrgov