Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make environments string constants #6

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

asteel-gsa
Copy link

Replaces the hardcoded environments with string constants

@asteel-gsa asteel-gsa linked an issue Jun 24, 2024 that may be closed by this pull request
@asteel-gsa asteel-gsa requested a review from jadudm June 24, 2024 15:40
Copy link

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should make us robust to naming issues in the future.

@asteel-gsa asteel-gsa added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 5ab6ef1 Jun 24, 2024
1 check passed
@asteel-gsa asteel-gsa deleted the env-string-constants branch July 1, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakout environments as string constants
2 participants