Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation cleanup and updates #469

Merged
merged 6 commits into from
Jan 31, 2025
Merged

Documentation cleanup and updates #469

merged 6 commits into from
Jan 31, 2025

Conversation

danielnaab
Copy link
Contributor

The documentation has gotten slightly out of date. This branch updates some terminology, modifies ADRs whose implementation has changed, and documents the architecture more clearly.

Copy link

github-actions bot commented Jan 29, 2025

Terraform plan for tts-10x-forms-dev

Plan: 0 to add, 1 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place

Terraform will perform the following actions:

  # cloudfoundry_app.tts-10x-forms-dev-server-doj_tts-10x-forms-dev-server-doj-app_22D74DC4 will be updated in-place
!~  resource "cloudfoundry_app" "tts-10x-forms-dev-server-doj_tts-10x-forms-dev-server-doj-app_22D74DC4" {
!~      docker_image                    = "ghcr.io/gsa-tts/forms/server-doj:b2bfed0d9e6598e557b39e709bbc7ceaeabd7fbf" -> "ghcr.io/gsa-tts/forms/server-doj:0cf23084acd976e8eba90118ec261cfc34d40bc3"
        id                              = "29c93a0a-519c-454a-847e-cc603395c2da"
        name                            = "tts-10x-forms-dev-server-doj-app"
#        (17 unchanged attributes hidden)

#        (3 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

📝 Plan generated in Post Terraform plan to PR comment #662


subgraph platform["Forms Platform (Internal)"]
style platform fill:#fcf8d4,color:#000
webServer[Platform Server: Handles form creation, submission, and interactions]:::blue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change: Should we update the background or text color for webServer to improve its visibility?
Screenshot 2025-01-31 at 7 43 48 AM

@danielnaab danielnaab force-pushed the document-architecture branch from 1170ba2 to 1e2830e Compare January 31, 2025 16:18
@danielnaab danielnaab merged commit 08cef3c into main Jan 31, 2025
3 of 4 checks passed
@danielnaab danielnaab deleted the document-architecture branch January 31, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants