This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
added grok rules and created logstack-shipper in dev #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 698ac79.
Fix localstack
FuhuXia
reviewed
Dec 28, 2023
6 tasks
btylerburton
reviewed
Jan 5, 2024
Jin-Sun-tts
changed the title
jbrown-xentity
approved these changes
Jan 10, 2024
Comment on lines
+1
to
+8
| --- | ||
| name: dev-deploy | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - development | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Do we want to setup similar things for staging and prod?
There was a problem hiding this comment.
I think that exists above in deploy.yml, as far as I can tell. Would it be beneficial then to combine them and make environ a variable?
There was a problem hiding this comment.
Staging and prod setup are already included in the deploy.yml file. For debug purpose we separate development out so we may test/debug any changes push to development brunch first instead of master brunch.
There was a problem hiding this comment.
This seems worthwhile to merge and road test in development. If we want to consolidate in the future, we can do so.
FuhuXia
reviewed
Jan 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes for GSA/data.gov#4234