Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluralization around text, fixing conditionals, making bar chart more visible #2311

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

heyitsmebev
Copy link
Contributor

@heyitsmebev heyitsmebev commented Jan 30, 2025

This PR addresses pluralization with the status banner, remove duplicate code, and add additional conditions to the job status column with the activity table.

Screenshot 2025-01-29 at 4 30 39 PM Screenshot 2025-01-29 at 4 30 20 PM

@heyitsmebev heyitsmebev changed the title pluralization and fixing conditionals Pluralization around text, fixing conditionals, making bar chart more visible Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good here especially

Copy link

@dmvancura dmvancura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the singular and pluralization fixes are as i expect for messages sending, message sent, and others. thank you Bev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants