Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic scan warnings #2321

Merged
merged 9 commits into from
Feb 10, 2025
Merged

dynamic scan warnings #2321

merged 9 commits into from
Feb 10, 2025

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Feb 5, 2025

Description

When this ticket was written, there were 10 zap warnings. This PR fixes three of them and declares one of them to be a false positive.

The outstanding 6 warnings look like real warnings that need to be fixed at some point.

Security Considerations

This improves security.

@terrazoon terrazoon self-assigned this Feb 6, 2025
@terrazoon terrazoon linked an issue Feb 6, 2025 that may be closed by this pull request
3 tasks
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@ccostino ccostino merged commit a4963b8 into main Feb 10, 2025
11 checks passed
@ccostino ccostino deleted the notify-admin-2315 branch February 10, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address new dynamic-scan findings
3 participants