fix tests

GTBitsOfGood · Mar 30, 2024 · 85fc732 · 85fc732
1 parent 2e893f2
commit 85fc732
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 25 deletions.
diff --git a/packages/logging-service/src/app.module.ts b/packages/logging-service/src/app.module.ts
@@ -3,7 +3,8 @@ import { AppController } from './app.controller';
 import { AppService } from './app.service';
 import { LoggingModule } from './modules/logging/logging.module';
 import { ClientsModule, Transport } from '@nestjs/microservices';
-import * as path from 'path';
+import { JUNO_LOGGING_PACKAGE_NAME } from 'juno-proto/dist/gen/logging';
+import { LoggingProtoFile } from 'juno-proto';
 
 @Module({
   imports: [
@@ -13,13 +14,8 @@ import * as path from 'path';
         name: 'LOGGING_SERVICE',
         transport: Transport.GRPC,
         options: {
-          package: 'error_logging',
-          protoPath: path.join(
-            __dirname,
-            '../../',
-            'juno-proto/dist/definitions',
-            'error_logging.proto',
-          ),
+          package: JUNO_LOGGING_PACKAGE_NAME,
+          protoPath: [LoggingProtoFile],
         },
       },
     ]),

diff --git a/packages/proto/definitions/error_logging.proto b/packages/proto/definitions/error_logging.proto
diff --git a/packages/proto/definitions/logging.proto b/packages/proto/definitions/logging.proto
@@ -4,10 +4,18 @@ package juno.logging;
 
 service LoggingService {
     rpc recordInfo(RecordInfoRequest) returns (RecordInfoResponse);
+    rpc recordError (ErrorLogRequest) returns (ErrorLogResponse) {}
 }
 
 message RecordInfoRequest {
     string message = 1;
 }
 
-message RecordInfoResponse {}
+message RecordInfoResponse {}
+
+message ErrorLogRequest {
+  string message = 1;
+}
+
+// TODO: to be defined later
+message ErrorLogResponse {}
diff --git a/packages/proto/src/gen/logging.ts b/packages/proto/src/gen/logging.ts
@@ -10,10 +10,19 @@ export interface RecordInfoRequest {
 
 export interface RecordInfoResponse {}
 
+export interface ErrorLogRequest {
+  message: string;
+}
+
+/** TODO: to be defined later */
+export interface ErrorLogResponse {}
+
 export const JUNO_LOGGING_PACKAGE_NAME = 'juno.logging';
 
 export interface LoggingServiceClient {
   recordInfo(request: RecordInfoRequest): Observable<RecordInfoResponse>;
+
+  recordError(request: ErrorLogRequest): Observable<ErrorLogResponse>;
 }
 
 export interface LoggingServiceController {
@@ -23,11 +32,18 @@ export interface LoggingServiceController {
     | Promise<RecordInfoResponse>
     | Observable<RecordInfoResponse>
     | RecordInfoResponse;
+
+  recordError(
+    request: ErrorLogRequest,
+  ):
+    | Promise<ErrorLogResponse>
+    | Observable<ErrorLogResponse>
+    | ErrorLogResponse;
 }
 
 export function LoggingServiceControllerMethods() {
   return function (constructor: Function) {
-    const grpcMethods: string[] = ['recordInfo'];
+    const grpcMethods: string[] = ['recordInfo', 'recordError'];
     for (const method of grpcMethods) {
       const descriptor: any = Reflect.getOwnPropertyDescriptor(
         constructor.prototype,