New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docker issue #10

Merged

tmthecoder merged 3 commits into main from docker-compose-fixes

Oct 24, 2023

Contributor

tmthecoder commented Oct 24, 2023

Fixes the docker issues that prevented builds from running via docker-compose if yarn install was not yet run
- Done by reworking Dockerfiles to install node modules in a parent directory and provide global executables (prisma/nest)
Fixes some context and volume mounting in the compose file

tmthecoder added 3 commits

October 24, 2023 01:04


          fix missing dep in gateway

f22dfcd


          rewrite dockerfile to place node_modules one directory above volume dir

314e096


          Rewrite docker-compose-dev to use correct contexts and volume locations

e3d3dd7

tmthecoder force-pushed the docker-compose-fixes branch from 554ad5f to e3d3dd7 Compare

October 24, 2023 05:05

SamratSahoo self-requested a review

October 24, 2023 05:29

SamratSahoo approved these changes

View reviewed changes

Member

SamratSahoo left a comment

Idk what this does but LGTM!

tmthecoder merged commit 1d2335e into main

1 check passed

tmthecoder deleted the docker-compose-fixes branch

October 24, 2023 05:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet