Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker dev improvements #12

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Docker dev improvements #12

merged 2 commits into from
Oct 29, 2023

Conversation

tmthecoder
Copy link
Contributor

Changes docker to use a top-level docker file for the monorepo (with separate targets per service) instead of a different docker file in each of the projects.

Also allows us to use the same dependency installation across all service builds instead of needing to wait for installs per-service

@SamratSahoo SamratSahoo self-requested a review October 29, 2023 16:05
Copy link
Member

@SamratSahoo SamratSahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk what this does either but LGTM!!!!

@tmthecoder tmthecoder merged commit 3098076 into main Oct 29, 2023
1 check passed
@tmthecoder tmthecoder deleted the docker-dev-improvements branch October 29, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants