Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Tests for User API #25

Merged
merged 10 commits into from
Feb 8, 2024
Merged

E2E Tests for User API #25

merged 10 commits into from
Feb 8, 2024

Conversation

jaipise
Copy link
Contributor

@jaipise jaipise commented Feb 5, 2024

  • a couple of tests not working completely yet (to do with retrieving specific IDs)

@tmthecoder
Copy link
Contributor

@jaipise Make sure all the GitHub actions workflows pass (formatting & e2e tests)

@jaipise
Copy link
Contributor Author

jaipise commented Feb 6, 2024

@jaipise Make sure all the GitHub actions workflows pass (formatting & e2e tests)

I fixed the formatting/linting but for some reason the project retrieval works but the linking is still not working. Was wondering if you could help me out with this?

@jaipise jaipise marked this pull request as ready for review February 6, 2024 03:46
@tmthecoder
Copy link
Contributor

@jaipise I just rebased your commits on top of the current main branch. Also left reviews on how to fix up the linking tests in comments. Look at Long's tests: https://github.com/GTBitsOfGood/juno/pull/28/files as another example

Copy link
Contributor

@tmthecoder tmthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@tmthecoder tmthecoder merged commit 833d7a1 into main Feb 8, 2024
4 checks passed
@tmthecoder tmthecoder deleted the jai-17-userAPI-tests branch February 8, 2024 19:22
@tmthecoder tmthecoder linked an issue Feb 14, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for User API Endpoint
2 participants