Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anthony/api key environment #54

Merged
merged 11 commits into from
Mar 4, 2024
Merged

Anthony/api key environment #54

merged 11 commits into from
Mar 4, 2024

Conversation

ahong75
Copy link
Contributor

@ahong75 ahong75 commented Feb 29, 2024

I couldn't figure out how to create a migration through Prisma CLI so I ended up just creating it manually. Unfortunately, in order to get the tests to run, I had to delete the line "yarn prisma migrate dev" from entrypoint.sh which shouldn't need to be done if the migration was auto generated I believe. Otherwise, I just hang at a certain point. I checked the logs and it seems this is because the terminal is prompting for a name for the migration. Also interestingly, if I had two of the same migrations, then the tests would also run fine. Sorry for the bad practice.

@ahong75 ahong75 marked this pull request as ready for review March 1, 2024 17:06
Copy link
Contributor

@tmthecoder tmthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just redid the migration piece so the auto-generation worked

@tmthecoder tmthecoder merged commit d5e2827 into main Mar 4, 2024
5 checks passed
@tmthecoder tmthecoder deleted the anthony/api-key-environment branch March 4, 2024 18:35
@tmthecoder tmthecoder linked an issue Mar 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add environment field for ApiKey
2 participants